Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature adding no colors to run command #1791

Conversation

budde377
Copy link
Member

@budde377 budde377 commented Jan 7, 2016

This will solve #1067 but also make some quite invasive changes. Including changing the constructor of the std. reporters. Since these should be generated with injection (according to this todo) this might not be such a big change after all.

Furthermore this allows setting the color properties on an adapter for deciding if a given reporter should write to it.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@dignifiedquire
Copy link
Member

Thanks, could please try either cherry-picking your commits into a new branch, or rebasing this one onto master as there seem to be some conflicts at the moment and it's hard to review like this.

@googlebot
Copy link

CLAs look good, thanks!

@budde377
Copy link
Member Author

budde377 commented Jan 9, 2016

Here you go!

@dignifiedquire
Copy link
Member

This will need some merging with master please

@budde377
Copy link
Member Author

Yes, will do this afternoon.

On Tue, Jan 19, 2016, 22:23 Friedel Ziegelmayer notifications@github.com
wrote:

This will need some merging with master please


Reply to this email directly or view it on GitHub
#1791 (comment).

 Add colors and log-level arguments to run argument.
 Refactor log-setup functions for server and init.
 Correct bug in server where log-level was ignored before `parseConfig`

Closing karma-runner#1067
Delay the decision on color/no-color reporter to write. This is
done by letting the individual adapter decide the color and providing
a default color to the base adapter.

Closing karma-runner#1067
@budde377 budde377 force-pushed the feature-adding-no-colors-to-run-command branch from 7b9fa96 to 486c4f3 Compare January 20, 2016 16:55
@budde377
Copy link
Member Author

Well, its afternoon somewhere. Here you go!

@dignifiedquire dignifiedquire removed their assignment Jan 20, 2016
@dignifiedquire
Copy link
Member

Thanks :octocat: you rock!

dignifiedquire added a commit that referenced this pull request Jan 20, 2016
…n-command

Feature adding no colors to run command
@dignifiedquire dignifiedquire merged commit 56073fc into karma-runner:master Jan 20, 2016
dignifiedquire added a commit to dignifiedquire/karma that referenced this pull request Feb 12, 2016
…dding-no-colors-to-run-command"

This reverts commit 56073fc, reversing
changes made to b7d591f.
dignifiedquire added a commit to dignifiedquire/karma that referenced this pull request Feb 12, 2016
…dding-no-colors-to-run-command"

Fixes karma-runner#1894, karma-runner#1895

This reverts commit 56073fc, reversing
changes made to b7d591f.
dignifiedquire added a commit to dignifiedquire/karma that referenced this pull request Feb 12, 2016
…dding-no-colors-to-run-command"

This reverts commit 56073fc, reversing
changes made to b7d591f.

This reverts commit 56073fc, reversing
changes made to b7d591f.

Fixes karma-runner#1894, karma-runner#1895
dignifiedquire added a commit to dignifiedquire/karma that referenced this pull request Feb 12, 2016
…dding-no-colors-to-run-command"

This reverts commit 56073fc, reversing
changes made to b7d591f.

Fixes karma-runner#1894, karma-runner#1895
dignifiedquire added a commit that referenced this pull request Feb 12, 2016
revert: "Merge pull request #1791 from budde377/feature-adding-no-col…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants