-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config): Allow custom context and debug files #1825
feat(config): Allow custom context and debug files #1825
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
Thanks, this looks pretty good but we need a test to ensure this works as expected. Could you take a look at the e2e tests and create one that uses a custom one and just test that is used |
Hi @dignifiedquire, I will try to do that. Firstly though, can you help me with the above error message? I'm basically just trying to run |
Make sure you run this before $ npm install
$ rm -rf node_modules/karma
$ cd node_modules
$ ln -s ../ karma
$ cd ../
$ grunt browserify |
@ernsheong ping |
@dignifiedquire Hi sorry for the delay. Can you teach me how to debug within PhantomJS? Or better still, how can I use the Chrome debugger to debug the feature test? |
You can specify temporary to use Chrome in the feature test like this: https://github.com/karma-runner/karma/blob/master/test/e2e/basic.feature#L23-L38 |
Sorry, I'm stuck. (not a Node guy, more front end). How can I debug the |
@ernsheong all code in |
Most of the path resolution and logic happens on the Node side. Something is not wired up right as I am unable to get the test to pass. Another eye would be helpful. |
@ernsheong I made a PR to your repository with the changes needed to pass the test. I am having some issues with PhantomJS on my machine and was only able to test my changes using Chrome. Please let me know if they don't work. |
3c88ef3
to
225c0e5
Compare
@dignifiedquire I finally got it to work! There was some weirdness for the cucumber mocha test, but I found a way to make it work... |
Thanks a lot! |
feat(config): Allow custom context and debug files
Continuation of #1586 and #1360
Potential progress/fix for #1752