-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Call .resume() on process streams so they don't get blocked #2267
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
@@ -284,7 +284,8 @@ | |||
"Jon Bretman <jon.bretman@gmail.com>", | |||
"Jonathan ES Lin <ernsheong@gmail.com>", | |||
"Julian Connor <julian.connor@venmo.com>", | |||
"Jurko Gospodnetić <jurko.gospodnetic@pke.hr>" | |||
"Jurko Gospodnetić <jurko.gospodnetic@pke.hr>", | |||
"Andrew Morris <voltrevo@gmail.com>" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove this please, these get autogenerated on release.
3fa931e
to
8806e1a
Compare
@dignifiedquire fixed |
Thanks |
If you manage to make chrome emit errors in the console, like we do with webrtc, the node stream buffer for stderr fills up and locks up the browser. This just calls
.resume()
to prevent that.Here's a tarball of a simplified project that repro's the issue:
https://drive.google.com/file/d/0By71SGpctHHxVzl1bkx6bGg3b2c/view?usp=sharing
Simply run
karma start --browsers ChromeFakeDevices
and chrome should lock up when it's done around 200 of the 1000 identical tests.