chore(test): fix flaky test cases #3314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karma-runner@cc2eff2 introduced different behavior depending on whether socket reconnected or browser reconnected after reload. This lead to the reconnecting test being flaky as depending on the timing it will trigger second test run and result in unexpected output.
devoto13
changed the title
The issue is that it resulted in the following sequence of actions: - run karma start - run karma run - and then instantly kill karma start command This resulted in flaky tests because preliminary killing resulted in incomplete output. In fact test was unnecessary complicated as it was enough to use runOut, which asserts output of the karma run command.
'data' event handler may be called multiple times, which will result in multiple calls to karma run. To take it even further its execution is delayed by setTimeout, which means that subsequent executions will run while next test scenario is in progress and may mess it up. To prevent this make sure that karma run is executed only once independently of how many time 'data' event is fired.
devoto13
changed the title
|
@johnjbarton This is ready for review. Please check separate commits to make review easier. It doesn't really make sense to split commits into separate PRs as they target same issue and have a combined effect. Hopefully this will make tests more stable and unblock my other PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See separate commits for details on fixed issues.