Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Preprocessor can return Promise #3376

Merged
merged 1 commit into from
Oct 11, 2019

Conversation

anthony-redFox
Copy link
Contributor

Similar that mocha support like you can execute done or return Promise

similar that mocha support like you can execute done or return Promise
@karmarunnerbot
Copy link
Member

Build karma 9 completed (commit 2c80f8e24c by @anthony-redFox)

@AppVeyorBot
Copy link

Build karma 2407 completed (commit 2c80f8e24c by @anthony-redFox)

@karmarunnerbot
Copy link
Member

Build karma 8 completed (commit 2c80f8e24c by @anthony-redFox)

Copy link
Contributor

@johnjbarton johnjbarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first commit is ready but I'd like to look at the second commit separately

lib/preprocessor.js Outdated Show resolved Hide resolved
@AppVeyorBot
Copy link

Build karma 2409 completed (commit 47c2de6151 by @anthony-redFox)

@karmarunnerbot
Copy link
Member

Build karma 11 completed (commit 47c2de6151 by @anthony-redFox)

@karmarunnerbot
Copy link
Member

Build karma 10 completed (commit 47c2de6151 by @anthony-redFox)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants