fix(middleware): Catch errors when loading a module (#3572)

[jehon]

Fix #3572

[karmarunnerbot]

✅ Build karma 380 completed (commit 891635fc48 by @jehon)

[AppVeyorBot]

✅ Build karma 2778 completed (commit 891635fc48 by @jehon)

[karmarunnerbot]

✅ Build karma 379 completed (commit 891635fc48 by @jehon)

[karmarunnerbot]

✅ Build karma 381 completed (commit 2b0c20184c by @jehon)

[AppVeyorBot]

✅ Build karma 2779 completed (commit 2b0c20184c by @jehon)

[karmarunnerbot]

✅ Build karma 380 completed (commit 2b0c20184c by @jehon)

[karmarunnerbot]

✅ Build karma 382 completed (commit 3054fc50b0 by @jehon)

[AppVeyorBot]

✅ Build karma 2780 completed (commit 3054fc50b0 by @jehon)

[karmarunnerbot]

✅ Build karma 381 completed (commit 3054fc50b0 by @jehon)

[AppVeyorBot]

✅ Build karma 2781 completed (commit 1c220fa432 by @jehon)

[karmarunnerbot]

✅ Build karma 383 completed (commit 1c220fa432 by @jehon)

[karmarunnerbot]

✅ Build karma 382 completed (commit 1c220fa432 by @jehon)

[karmarunnerbot]

✅ Build karma 384 completed (commit 5f389087bd by @jehon)

[AppVeyorBot]

✅ Build karma 2782 completed (commit 5f389087bd by @jehon)

[karmarunnerbot]

✅ Build karma 383 completed (commit 5f389087bd by @jehon)

[jehon]

@johnjbarton Sorry to interrupt you, but could you have an (updated) opinion on this PR?
The basis is that, without this PR and actually, karma report success when there is a syntax error in a es6 test.

[jehon]

Could someone review this PR?
If some work need to be done, could it be said?
Thanks

[johnjbarton]

Sorry for the long delay. I want to investigate the possibility of correcting any tests that fail with the error on both paths.

[jehon]

I did look into the failings tests, nothing important. It's just that it test the string, and that in need to be adapted. I can push it here if wanted.

But the problem is that the output would change for errors in normal scripts (here, I put a call to "nothing()":

Uncaught ReferenceError: nothing is not defined
ReferenceError: nothing is not defined
   at tests/failing-test.js:2:1

Instead of

ReferenceError: nothing is not defined
   at tests/failing-test.js:2:1

There is no difference with the "if".

[jehon]

Followup in #3585

[jehon]

Followup in #3605