-
Notifications
You must be signed in to change notification settings - Fork 899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update chart-testing-action to v2.6.0 and cosigin-installer to v3.1.1 #4201
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/assign
Seems this might be a blocker for the other's PR.
/priority important-soon
Seems this is due to Sigstore no longer publishing cosign releases to GCS bucket. There is an instruction for updating GitHub Actions if people using
Do we need to update them? |
Thanks for remind and i have tested it with Also tested it with So we can update the installer version and keep the same cosign version. |
* Update cosign-installer to v3.1.1, see https://blog.sigstore.dev/cosign-releases-bucket-deprecation/ Signed-off-by: Lan Liang <gcslyp@gmail.com>
9d5a12d
to
b261534
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4201 +/- ##
==========================================
- Coverage 52.85% 52.82% -0.03%
==========================================
Files 239 239
Lines 23558 23558
==========================================
- Hits 12451 12445 -6
- Misses 10431 10436 +5
- Partials 676 677 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Actually we don't need to bump sigstore/cosign-installer
as the action downloads the sigstore
binary directly from GitHub(not the deprecated Google Bucket):
See the code for more details:
https://github.com/sigstore/cosign-installer/blob/main/action.yml#L184-L185
But it's not harm to bump it to a higher version.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
update v3.0.3 to download cosign from GitHub instead of GCS
It's true, and it's download from GCS when using csogin-installer with hash to a version earlier than v3.1.0. And karmada is using tag. |
I don't get why it is the v3.1.0. I think any hash version earlier than v3.0.3 also downloads from GCS. |
…#4201-upstream-release-1.7 [1.7] Automated cherry pick of #4201: * Update chart-testing-action to v2.6.0
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
helm chart testing action is broken, https://github.com/karmada-io/karmada/actions/runs/6706548301/job/18223260799
xref:
targetBranch main does not exist
helm/chart-testing-action#133I have try to update to v2.5.0 and it's not working. https://github.com/liangyuanpeng/karmada/actions/runs/6714930957
And v2.6.0 can fix it.
Since we are using cosign separately, it is better to follow the notification to upgrade the installer version.
So this PR have two change:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: