-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use merge strategy to avoid work.karmada.io/permanent-id changes #4793
Use merge strategy to avoid work.karmada.io/permanent-id changes #4793
Conversation
Signed-off-by: whitewindmills <jayfantasyhjh@gmail.com>
f8a17a6
to
9c08138
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4793 +/- ##
==========================================
+ Coverage 51.75% 51.76% +0.01%
==========================================
Files 250 250
Lines 24980 24980
==========================================
+ Hits 12928 12931 +3
+ Misses 11342 11339 -3
Partials 710 710
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice finding! Did you discover the problem during development?
/lgtm
/kind bug
Yes, this causes CI to always fail. |
Another PR #4743 still needs this, could you take look? |
Hi @whitewindmills, how about adding the release note, I think we should cherry-pick this patch to the previous branch, how do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…k-of-#4793-upstream-release-1.8 Automated cherry pick of #4793: Use merge strategy to avoid work.karmada.io/permanent-id
…k-of-#4793-upstream-release-1.9 Automated cherry pick of #4793: Use merge strategy to avoid work.karmada.io/permanent-id
What type of PR is this?
/kind bug
What this PR does / why we need it:
Since labels will be overwritten every time they are updated and created, this causes
work.karmada.io/permanent-id
to constantly change.I add some debug logs in karmada-webhook to capture the bug:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: