Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use merge strategy to avoid work.karmada.io/permanent-id changes #4793

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

whitewindmills
Copy link
Member

@whitewindmills whitewindmills commented Apr 2, 2024

What type of PR is this?
/kind bug

What this PR does / why we need it:
Since labels will be overwritten every time they are updated and created, this causes work.karmada.io/permanent-id to constantly change.
I add some debug logs in karmada-webhook to capture the bug:
image

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

karmada-controller-manager: Fix the problem that work.karmada.io/permanent-id constantly changes with every update.

Signed-off-by: whitewindmills <jayfantasyhjh@gmail.com>
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 3, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 51.76%. Comparing base (a0c0a98) to head (9c08138).

Files Patch % Lines
pkg/util/helper/work.go 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4793      +/-   ##
==========================================
+ Coverage   51.75%   51.76%   +0.01%     
==========================================
  Files         250      250              
  Lines       24980    24980              
==========================================
+ Hits        12928    12931       +3     
+ Misses      11342    11339       -3     
  Partials      710      710              
Flag Coverage Δ
unittests 51.76% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@whitewindmills
Copy link
Member Author

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice finding! Did you discover the problem during development?

/lgtm
/kind bug

@karmada-bot karmada-bot added kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. labels Apr 3, 2024
@whitewindmills
Copy link
Member Author

Did you discover the problem during development?

Yes, this causes CI to always fail.

@whitewindmills
Copy link
Member Author

Another PR #4743 still needs this, could you take look?
/cc @RainbowMango

@karmada-bot karmada-bot requested a review from RainbowMango April 3, 2024 07:13
@XiShanYongYe-Chang
Copy link
Member

Hi @whitewindmills, how about adding the release note, I think we should cherry-pick this patch to the previous branch, how do you think?

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 3, 2024
@karmada-bot karmada-bot merged commit 4f99ebd into karmada-io:master Apr 3, 2024
12 checks passed
karmada-bot added a commit that referenced this pull request Apr 10, 2024
…k-of-#4793-upstream-release-1.8

Automated cherry pick of #4793: Use merge strategy to avoid work.karmada.io/permanent-id
karmada-bot added a commit that referenced this pull request Apr 10, 2024
…k-of-#4793-upstream-release-1.9

Automated cherry pick of #4793: Use merge strategy to avoid work.karmada.io/permanent-id
@whitewindmills whitewindmills deleted the fix-work-permanentID branch April 19, 2024 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants