Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing command line arguments for karmada-operator #5174

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

whitewindmills
Copy link
Member

@whitewindmills whitewindmills commented Jul 11, 2024

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmada-operator`: Introduced `--metrics-bind-address` and `--health-probe-bind-address` flags, it's a compatible change as the default value does not change from previous versions. 

@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jul 11, 2024
@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 11, 2024
@whitewindmills
Copy link
Member Author

PTAL
/assign @chaosi-zju @RainbowMango

@chaosi-zju
Copy link
Member

looks good

@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 28.26%. Comparing base (71de3dc) to head (a9853d0).
Report is 39 commits behind head on master.

Files Patch % Lines
operator/cmd/operator/app/options/options.go 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5174      +/-   ##
==========================================
+ Coverage   28.22%   28.26%   +0.03%     
==========================================
  Files         632      632              
  Lines       43566    43739     +173     
==========================================
+ Hits        12296    12362      +66     
- Misses      30371    30476     +105     
- Partials      899      901       +2     
Flag Coverage Δ
unittests 28.26% <0.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: whitewindmills <jayfantasyhjh@gmail.com>
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Luckily, we haven't exposed the two flags yet, so we can skip the deprecation period.

Please @zhzhuang-zju help to take another look.

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2024
@zhzhuang-zju
Copy link
Contributor

thanks~
/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2024
@karmada-bot karmada-bot merged commit 871e2bf into karmada-io:master Jul 18, 2024
12 checks passed
@whitewindmills whitewindmills deleted the operator-options branch July 18, 2024 09:07
@RainbowMango RainbowMango added this to the v1.11 milestone Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants