-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing command line arguments for karmada-operator #5174
Add missing command line arguments for karmada-operator #5174
Conversation
PTAL |
looks good |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5174 +/- ##
==========================================
+ Coverage 28.22% 28.26% +0.03%
==========================================
Files 632 632
Lines 43566 43739 +173
==========================================
+ Hits 12296 12362 +66
- Misses 30371 30476 +105
- Partials 899 901 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
8c1ebe7
to
b12bcf4
Compare
Signed-off-by: whitewindmills <jayfantasyhjh@gmail.com>
b12bcf4
to
a9853d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Luckily, we haven't exposed the two flags yet, so we can skip the deprecation period.
Please @zhzhuang-zju help to take another look.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
thanks~ |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: