Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zh: adds karmadactl flags for proper display #764

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

zh: adds karmadactl flags for proper display #764

wants to merge 1 commit into from

Conversation

zhzhuang-zju
Copy link
Contributor

What type of PR is this?
/kind documentation

What this PR does / why we need it:
Refer to #763 (comment)

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

@karmada-bot karmada-bot added the kind/documentation Categorizes issue or PR as related to documentation. label Dec 16, 2024
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 16, 2024
@zhzhuang-zju
Copy link
Contributor Author

karmadactl introduced the operation-scope flag starting from version 1.11.0, and the corresponding documentation needs to be updated.

cc @LavredisG @RainbowMango

samzong
samzong reviewed Dec 16, 2024
View reviewed changes
Copy link
Member

@samzong samzong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2024
RainbowMango
RainbowMango approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2024
@zhzhuang-zju
Copy link
Contributor Author

/retest

@zhzhuang-zju
Copy link
Contributor Author

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory

https://app.netlify.com/sites/karmada/deploys/675fce07d8baa700087e6d73#L164

@zhzhuang-zju
zh: adds karmadactl flags for proper display
43fc71a 
Signed-off-by: zhzhuang-zju <m17799853869@163.com>
@karmada-bot karmada-bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2024
@karmada-bot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samzong samzong samzong left review comments

@RainbowMango RainbowMango RainbowMango approved these changes

@Poor12 Poor12 Awaiting requested review from Poor12

@Tingtal Tingtal Awaiting requested review from Tingtal

Assignees

@RainbowMango RainbowMango

@samzong samzong

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhzhuang-zju @karmada-bot @RainbowMango @samzong