Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should allow using topp logic while avoiding the significant performance hit
Sampling probabilities tend to be sharp, so filtering out low probabilities before sorting the list result with significant time improvement for sample_topp.
We use a threshold that guaranties the filtered entries do not belong to topp (except for maybe a very rare edge case, need to think on it), but anyway we verify it to allow higher threshold.