Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the publicIpPrefix prop during VmssUpdate #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

karthikka4820
Copy link
Owner

@karthikka4820 karthikka4820 commented Aug 3, 2021

When a customer tries to scale VMSS using Terraform, since the current definitions do not have publicIpPrefix property, the new VM will be assigned a random IP address which is outside the range of public Ip prefix. Customer has to resolve the issue by deleting the Vmss and recreating it. This PR tries to resolve the issue by adding the publicIpPrefix property in the JSON definition which is used to generate a request for VMSS update.

More details about the issue can be found here - Azure#10190

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit (including refactoring) and then push new changes, including version updates, in separate commits.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

When a customer tries to scale VMSS using Terraform, since the current definitions do not have publicIpPrefix property, the new VM will be assigned a random IP address which is outside the range of public Ip prefix. Customer has to resolve the issue by deleting the Vmss and recreating it. This PR tries to resolve the issue by adding the publicIpPrefix property in the JSON definition which is used to generate a request for VMSS update. 

More details about the issue can be found here - Azure#10190
karthikka4820 pushed a commit that referenced this pull request Nov 23, 2021
…s fix and other changes (Azure#15962)

* new api changes (#1)

* new api changes

* referer url change

* EdgeOrder 2020-12-01-preview Swagger changes (Azure#5)

* readme changes

* Swagger refresh and update examples

* Change examples as per oav validations

* Minor swagger modifications

* Minor spacing adjustments

* Set ModelAsString to true for enums and modify examples

* Fix swagger lint validation error

* Modify readme and examples

* Modify readme.go.md

* Update swagger

* Minor prettier fix

* Change python package version in readme

* Fix spell check error

* chanegs to enable forward and reverse shipping details in get order item call using odata filter

* Swagger correctness fix with other changes (Azure#25)

* Swagger correctness fix with other changes

* Return api field additions

* Change expand description for listOrderItem calls

Co-authored-by: Vaishnavi Janardhan <vjanardhan@microsoft.com>

* Fix semantic validation error in doubleEncryptionStatus (Azure#30)

* Mark parameters of shipping details as readonly (Azure#35)

* Additional properties swagger correctness fix (Azure#43)

Co-authored-by: sashanm <54701252+sashanm@users.noreply.github.com>
Co-authored-by: t-vjanardhan <77781522+t-vjanardhan@users.noreply.github.com>
Co-authored-by: Nidhi Jain <nidhij@microsoft.com>
Co-authored-by: nija-dev <67132984+nija-dev@users.noreply.github.com>
Co-authored-by: Vaishnavi Janardhan <vjanardhan@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant