Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load map file in non-strict mode #3

Merged
merged 1 commit into from
Sep 26, 2018

Conversation

mdholloway
Copy link

Needed to avoid errors with fonts.

Bug: https://phabricator.wikimedia.org/T195513

Copy link

@thesocialdev thesocialdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing locally, in master there are 27 fails and in your branch 28 fails, I am not sure what it can be but I think we should double check.

@mdholloway
Copy link
Author

Most of the failures are due to the requirement to set a MapboxAccessToken environment variable with an API token from Mapbox before running the tests. This seems to be a new requirement since the tests were written. (Actually, it's also an open issue upstream: mapbox#153)

When I view my Mapbox account, it has a default public token that I think was auto-created when I created the account. Setting it as the value of the MapboxAccessToken env var got these tests passing. (Hopefully I won't be charged, still need to check...)

There are a couple of other tests failing due to an Amazon s3 auth failure somewhere, and these can be quieted by setting TILELIVE_VECTOR_NO_AUTH (see mapbox#116).

With these environment variables set, all tests pass for me both before and after this change. Can you verify?

@thesocialdev thesocialdev merged commit 694ff7d into kartotherian:master Sep 26, 2018
@mdholloway mdholloway deleted the non-strict branch September 26, 2018 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants