-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SKIP-943: expose optional metricsPort for certain applications #155
Conversation
Results for sandbox – ❗
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Veldig bra! Må deployere til dev før vi får testet Instana, men det burde jo gå fint :)
@@ -91,6 +90,15 @@ func (r *ApplicationReconciler) reconcileDeployment(ctx context.Context, applica | |||
|
|||
container.Ports = make([]corev1.ContainerPort, 1) | |||
container.Ports[0].ContainerPort = int32(application.Spec.Port) | |||
container.Ports[0].Name = "main" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slik det er i dag så mappes servicen til porten basert på indeksen, så navnet på port 0 blir ikke brukt til noe egentlig?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Det er korrekt. Tanken bak å navngi default-porten er for å kunne gjenbruke navnet på tvers i andre ressurser. Da gjør det ikke noe om selve portnummeret endrer seg over tid. Dette er dog ikke implementert i denne PR'en, men da ligger alt til rette for det.
Håpet er også at ekstern tooling skal kunne si noe om trafikkflyt på main-port vs metrics-port vs tertiær-porter. Det er lettere å forstå enn port 8080 for den app1 og port 4398 for app2
Lets applications expose an optional extra port in those cases where we want a metrics endpoint available through a different port than the standard one.