Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SKIP-1072 Set defaults properly #248

Merged
merged 7 commits into from
Jun 26, 2023
Merged

SKIP-1072 Set defaults properly #248

merged 7 commits into from
Jun 26, 2023

Conversation

omaen
Copy link
Contributor

@omaen omaen commented Jun 23, 2023 •
edited
Loading

The previous PR #246 introduced a continous reconcile-loop due to some default values for the Probes which resulted in a new Hash.

This PR sets the defaults for these fields.

@omaen omaen requested a review from a team as a code owner June 23, 2023 12:42
@omaen omaen requested review from evenh, berg-thom and BardOve June 23, 2023 12:42
@omaen omaen requested a review from anderssonw June 26, 2023 08:19
@omaen omaen added this pull request to the merge queue Jun 26, 2023
Merged via the queue into main with commit f6b96ab Jun 26, 2023
@omaen omaen deleted the allow-0-replicas-fix branch June 26, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anderssonw anderssonw anderssonw approved these changes

@evenh evenh evenh approved these changes

@berg-thom berg-thom Awaiting requested review from berg-thom berg-thom is a code owner automatically assigned from kartverket/skip

@BardOve BardOve Awaiting requested review from BardOve BardOve is a code owner automatically assigned from kartverket/skip

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@omaen @evenh @anderssonw