Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconfigure scraping when Istio is used #260

Merged
merged 2 commits into from
Jul 7, 2023
Merged

Reconfigure scraping when Istio is used #260

merged 2 commits into from
Jul 7, 2023

Conversation

evenh
Copy link
Member

@evenh evenh commented Jul 7, 2023

SKIP-1109

@evenh evenh requested a review from a team as a code owner July 7, 2023 10:44
@evenh evenh requested review from omaen, anderssonw and berg-thom July 7, 2023 10:44
anderssonw
anderssonw approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@anderssonw anderssonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly nitpicks so still lgtm :)

controllers/application/service.go Outdated Show resolved Hide resolved
controllers/application/service_monitor.go Outdated Show resolved Hide resolved
controllers/application/service_monitor.go Outdated Show resolved Hide resolved
@evenh evenh added this pull request to the merge queue Jul 7, 2023
Merged via the queue into main with commit ed943ca Jul 7, 2023
@evenh evenh deleted the prometheus+istio branch July 7, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berg-thom berg-thom berg-thom approved these changes

@anderssonw anderssonw anderssonw approved these changes

@omaen omaen Awaiting requested review from omaen omaen is a code owner automatically assigned from kartverket/skip

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evenh @anderssonw @berg-thom