Add missing app pod label to job pods

[martinhny]

https://kartverketgroup.slack.com/archives/C028ZEED280/p1724226929488839

Summary by CodeRabbit

• New Features

  • Enhanced labeling strategy in Kubernetes job configurations for better identification and management.
  • Added a new Pod definition to centralize label usage and establish clear ownership relationships.

• Performance Improvements

  • Reduced parallel execution parameter in configuration settings from 10 to 5, optimizing resource utilization.

• Bug Fixes

  • Improved organization of metadata labels in Job and Pod definitions to align with Kubernetes best practices.

[evenh]

@coderabbitai summary

[coderabbitai]

Actions performed

Summary regeneration triggered.

[coderabbitai]

Walkthrough

The recent changes enhance the labeling strategy in Kubernetes configurations, improving resource identification and management. Key modifications include adjustments to job specifications and CronJob metadata, optimizing label placements for better clarity. Additionally, the execution concurrency in tests has been reduced, impacting performance aspects. Overall, these updates streamline operations and refine the organization of Kubernetes resources.

Changes

File Path	Change Summary
pkg/resourcegenerator/job/job.go	Added a label to the jobSpec.Template for improved job identification.
tests/config.yaml	Changed parallel execution parameter from 10 to 5, reducing concurrent operations.
tests/skipjob/minimal-cron-job/skipjob-assert.yaml	Removed app label from CronJob metadata, retained it in pod spec; added new controller label; introduced a Pod definition with consistent labels.
tests/skipjob/minimal-job/skipjob-assert.yaml	Removed app label from Job metadata, added it to Pod metadata for improved identification.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant CronJob
    participant Pod
    participant Job

    User->>CronJob: Create CronJob
    CronJob->>Job: Schedule Job
    Job->>Pod: Create Pod with updated labels
    Pod-->>Job: Acknowledge creation
    Job-->>CronJob: Job completed
    CronJob-->>User: Notification of completion

Loading

Poem

🐇 In the garden where jobs do play,
Labels dance in a cheerful ballet.
With tweaks and trims, the pods align,
A smoother flow, oh how divine!
From ten to five, we’ll hop and cheer,
For better days are surely near! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.