Issue #44 PR #104
Open
Issue #44 PR #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, that's interesting. The tests reveal some unintended serializations coming out of Thanks! |
kasei
reviewed
Oct 26, 2016
|
|
||
| my $s = do { | ||
|
|
||
| if ($args{namespaces} && $self->value->isa('Attean::IRI')) { |
There was a problem hiding this comment.
Oops. Not all Attean::API::SPARQLSerializable objects will have a value method, so this will crash. I don't think the second part of the if condition is necessary, though, so it could just be if ($args{namespaces}) {...}
|
I see. No probs, let me know when you decide to merge and I will update tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the namespaces parmeter to as_sparql that accepts either the URI::NamespaceMap object or HASH ref that is then used to create the instance of URI::NamespaceMap inside the method.
#44
Zoran