Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented exact transaction builder rpc command #2051

Draft
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

tmrlvi
Copy link
Contributor

@tmrlvi tmrlvi commented May 14, 2022

This is a suggestion for new, powerful, mechanism in the wallet that allows building precise transactions based on relevant outpoints and payments. Since it gives full control over utxos and outputs, it is meant to be used by apps, and not by the wallet cli directly.

@codecov
Copy link

codecov bot commented May 14, 2022

Codecov Report

Base: 58.95% // Head: 59.26% // Increases project coverage by +0.30% 🎉

Coverage data is based on head (831b59f) compared to base (a3387a5).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head 831b59f differs from pull request most recent head 1db97cf. Consider uploading reports for the commit 1db97cf to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2051      +/-   ##
==========================================
+ Coverage   58.95%   59.26%   +0.30%     
==========================================
  Files         679      674       -5     
  Lines       33063    32357     -706     
==========================================
- Hits        19493    19176     -317     
+ Misses      10735    10421     -314     
+ Partials     2835     2760      -75     
Impacted Files Coverage Δ
...emon/server/create_unsigned_transaction_verbose.go 0.00% <0.00%> (ø)
app/protocol/flows/v5/blockrelay/block_locator.go 52.94% <0.00%> (-11.77%) ⬇️
...pc_get_virtual_selected_parent_chain_from_block.go 64.81% <0.00%> (-10.19%) ⬇️
app/rpc/rpchandlers/get_mempool_entry.go 41.17% <0.00%> (-8.83%) ⬇️
...ructure/network/rpcclient/grpcclient/grpcclient.go 76.56% <0.00%> (-5.26%) ⬇️
...nsensus/processes/consensusstatemanager/resolve.go 54.54% <0.00%> (-4.19%) ⬇️
...dapter/server/grpcserver/protowire/rpc_get_info.go 69.69% <0.00%> (-3.28%) ⬇️
...cesses/consensusstatemanager/reverse_utxo_diffs.go 64.44% <0.00%> (-3.00%) ⬇️
domain/consensus/test_consensus.go 47.40% <0.00%> (-2.94%) ⬇️
domain/consensus/test_consensus_getters.go 72.22% <0.00%> (-2.78%) ⬇️
... and 96 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tmrlvi tmrlvi force-pushed the advanced_create_usigned_transaction branch from 831b59f to 946d3a1 Compare November 16, 2022 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant