Fix duplicated kaspaminer help output #2267
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if
kaspaminer
isn't widely used anymore, it has some glitches with its command line argument processing. In Karlsen we still rely on the built-in miner and fixed it.First issue: If
./kaspaminer -h
is used, it shows the help twice and a Go trace at the end.Second issue: If
./kaspaminer
is executed without any argument, it shows correct error message but still a Go trace.Both issues are fixed with this pull request. For reference, downstream issues: karlsen-network#34 and karlsen-network#38