refactor: model (parts of) Context via associated module #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| Report | Tue, March 19, 2024 at 22:17:39 UTC |
| Project | laze |
| Branch | 425/merge |
| Testbed | github-actions |
| Benchmark | perf:task-clock | perf:task-clock Results msec | (Δ%) |
|---|---|---|
| laze -C RIOT build --global --generate-only | ✅ (view plot) | 9652.996 |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
2 tasks
kaspar030
force-pushed
the
context_as_modules
branch
from
a5a5923 to
92f8720
Compare
|
| Branch | 425/merge |
| Testbed | github-actions |
Click to view all benchmark results
| Benchmark | perf:task-clock | Benchmark Result msec (Result Δ%) | Upper Boundary msec (Limit %) |
|---|---|---|---|
| laze -C RIOT build --global --generate-only | 📈 view plot 🚷 view threshold | 9,422.12 (+1.56%) | 9,686.64 (97.27%) |
kaspar030
force-pushed
the
context_as_modules
branch
from
e0891e0 to
00edbea
Compare
kaspar030
force-pushed
the
context_as_modules
branch
from
ac2c224 to
43e413c
Compare
kaspar030
force-pushed
the
context_as_modules
branch
3 times, most recently
from
6850738 to
dc0bec5
Compare
kaspar030
force-pushed
the
context_as_modules
branch
from
a3939f1 to
b9f8310
Compare
kaspar030
force-pushed
the
context_as_modules
branch
3 times, most recently
from
98e3b02 to
ab9ab5f
Compare
kaspar030
force-pushed
the
context_as_modules
branch
from
ab9ab5f to
5bc8732
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables some nifty features:
This also implies that Tasks and Rules can have dependencies.
Internally, quite a bit of Context tree handling can probably be removed, as Modules form a similar tree.