Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please Support Mac Keys #173

Closed
brandondrew opened this issue Mar 13, 2017 · 14 comments
Closed

Please Support Mac Keys #173

brandondrew opened this issue Mar 13, 2017 · 14 comments
Assignees
Milestone

Comments

@brandondrew
Copy link

Phoenix looks very impressive, but has an aesthetic flaw.

OS X/macOS does not have any key named "cmd"—it has "command". (In fact, I'm not aware of any OS that has a "cmd" key.) Likewise, it does not have a key with "ctrl" printed on it, but rather "control".

It would be preferable for software that only runs on Macs to support the keys that Macs ship with:

  • command (not "cmd")
  • control (not "ctrl")
  • option ("alt" can be an alias, since Apple decided that this is the key to be used for "alt" when running Windows or connecting remotely to a machine running Windows.)

Thanks!

@kasper
Copy link
Owner

kasper commented Mar 13, 2017

Hi! I’m all for linguistics, but Apple previously shortened the keys as cmd, ctrl and alt. In the newer keyboards they aren’t anymore abbreviated. I can certainly add the full labels as aliases, but you can also do this in your configuration.

const command = 'cmd';
const control = 'ctrl';
const option = 'alt';

Key.on('q', [ command, control ], () => {});

@brandondrew
Copy link
Author

brandondrew commented Mar 15, 2017

I was skeptical, but it turns out you're right about 'ctrl'. Apple did print that as an abbreviation at one time.

http://xahlee.info/kbd/i2/Apple_extended_keyboard_1_1987.jpg

@kasper
Copy link
Owner

kasper commented Mar 15, 2017

@brandondrew LOL. You don’t have to go that far, MacBooks from a couple of years ago have it as “ctrl”.

@jasonm23
Copy link
Contributor

Funny, my old apple keyboard has Control...

@jasonm23
Copy link
Contributor

(It used to be one of these)

@kasper
Copy link
Owner

kasper commented Mar 15, 2017

Haha, this is getting nostalgic.

@mafredri
Copy link
Contributor

My MacBook Pro (Late 2013) says cmd, alt, ctrl. Nice try guys, I can smell the photoshop in those pictures!

@jasonm23
Copy link
Contributor

I can smell photoshop

Sorry no you can't. Any angle you'd like that board photographed from, I'm happy to oblige.

@jasonm23
Copy link
Contributor

:)

@jasonm23
Copy link
Contributor

Simulating low light CCD grain in Photoshop is tricky

@kasper
Copy link
Owner

kasper commented Mar 15, 2017

🎺

@brandondrew
Copy link
Author

I think the issue might be internationalization. Several (most?) of the keyboards I found online with abbreviations were localized for some language other than English. It's possible that this was done by some company other than Apple.

I don't personally remember ever seeing "ctrl" on an Apple keyboard, but the evidence is online.

Before people argue about a certain model year having or not having abbreviations, it might be useful to specify what language the keyboard was localized for.

Also, let's not let this become hostile. ☹️ I think we all agree that Phoenix is mega-awesome.

@kasper
Copy link
Owner

kasper commented Mar 15, 2017

Nothing hostile, I can definitely add the aliases.

@kasper
Copy link
Owner

kasper commented Jun 15, 2018

This travesty is now sorted! Thanks for the feedback. 👍

@kasper kasper closed this as completed Jun 15, 2018
@kasper kasper self-assigned this Jun 15, 2018
mafredri added a commit to mafredri/phoenix-typings that referenced this issue Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants