Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"-cl" is not valid with some shells (e.g. Fish) #57

Merged
merged 1 commit into from
Nov 29, 2015

Conversation

shayne
Copy link
Contributor

@shayne shayne commented Nov 29, 2015

Pass "-l" for login and "-c" for command, separately

Pass "-l" for login and "-c" for command, separately
@jasonm23
Copy link
Contributor

Good catch

jasonm23 added a commit that referenced this pull request Nov 29, 2015
"-cl" is not valid with some shells (e.g. Fish)
@jasonm23 jasonm23 merged commit 7f79815 into kasper:master Nov 29, 2015
@kasper
Copy link
Owner

kasper commented Nov 29, 2015

@shayne Thanks! 👍

@jasonm23 In the future, we should probably enforce the Contribution guidelines a bit more. I would like all pull requests that fix bugs or add new features to document the changes not only to the API, but Changelog as well (4.). This will make it easier to follow the changes on the master branch and not miss any potential Changelog notes. These should follow the existing categories and format for Changelog notes.

@jasonm23
Copy link
Contributor

Noted. This should be added to the Changelog for sure, my apologies.

On 30 Nov 2015, at 7:58 AM, Kasper Hirvikoski notifications@github.com wrote:

@shayne Thanks!

@jasonm23 In the future, we should probably enforce the Contribution guidelines a bit more. I would like all pull requests that fix bugs or add new features to document the changes not only to the API, but Changelog as well (4.). This will make it easier to follow the changes on the master branch and not miss any potential Changelog notes. These should follow the existing categories and format for Changelog notes.


Reply to this email directly or view it on GitHub.

@kasper
Copy link
Owner

kasper commented Nov 30, 2015

@jasonm23 No need to apologise! I’ve let this past a couple of times myself. It’s good do discuss these along the way. :)

@jasonm23
Copy link
Contributor

We can do adv. filtering on github issues. So we can collect PR/Issues closed within a time range btw.

No need to worry about forgetting them.

On 30 Nov 2015, at 8:47 AM, Kasper Hirvikoski notifications@github.com wrote:

@jasonm23 No need to apologise! I’ve let this past a couple of times myself. It’s good do discuss these along the way. :)


Reply to this email directly or view it on GitHub.

@kasper
Copy link
Owner

kasper commented Nov 30, 2015

@jasonm23 Sure, I’m just a very careful and organised person. As you might have noticed. :)

@jasonm23
Copy link
Contributor

: ) me too, in theory

On 30 Nov 2015, at 6:43 PM, Kasper Hirvikoski notifications@github.com wrote:

@jasonm23 Sure, I’m just a very careful and organised person. As you might have noticed. :)


Reply to this email directly or view it on GitHub.

@kasper kasper added the bug label Dec 7, 2015
@kasper kasper added this to the 2.0.1 milestone Dec 7, 2015
kasper added a commit that referenced this pull request Dec 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants