Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

delete: force: Do not fail on non exiting container #1219

Closed
jcvenegas opened this issue Feb 7, 2019 · 0 comments
Closed

delete: force: Do not fail on non exiting container #1219

jcvenegas opened this issue Feb 7, 2019 · 0 comments

Comments

@jcvenegas
Copy link
Member

Description of problem

When a container does not exist, runc does not fail. Lets mimic this
behavior, sometimes kuberentes will try to force delete containers that
could not be created and gets confused if delete --force fails.

Expected result

kata-runtime delete --force THIS_CONTAINER_NOT_EXIST 
echo $?
1

Actual result

kata-runtime delete --force THIS_CONTAINER_NOT_EXIST 
echo $?
0

(replace this text with the output of the kata-collect-data.sh script, after
you have reviewed its content to ensure it does not contain any private
information).

jcvenegas added a commit to jcvenegas/runtime that referenced this issue Feb 7, 2019
When a container does not exist, runc does not fail.  Lets mimic this
behavior, sometimes kuberentes will try to force delete containers that
could not be created and gets confused if delete --force fails.

Fixes: kata-containers#1219

Signed-off-by: Jose Carlos Venegas Munoz <jose.carlos.venegas.munoz@intel.com>
jcvenegas added a commit to jcvenegas/runtime that referenced this issue Feb 18, 2019
When a container does not exist, runc does not fail.  Lets mimic this
behavior, sometimes kuberentes will try to force delete containers that
could not be created and gets confused if delete --force fails.

Fixes: kata-containers#1219

Signed-off-by: Jose Carlos Venegas Munoz <jose.carlos.venegas.munoz@intel.com>
jcvenegas added a commit to jcvenegas/runtime that referenced this issue Feb 18, 2019
When a container does not exist, runc does not fail.  Lets mimic this
behavior, sometimes kuberentes will try to force delete containers that
could not be created and gets confused if delete --force fails.

Fixes: kata-containers#1219

Signed-off-by: Jose Carlos Venegas Munoz <jose.carlos.venegas.munoz@intel.com>
egernst pushed a commit to egernst/runtime that referenced this issue Feb 26, 2019
When a container does not exist, runc does not fail.  Lets mimic this
behavior, sometimes kuberentes will try to force delete containers that
could not be created and gets confused if delete --force fails.

Fixes: kata-containers#1219

Signed-off-by: Jose Carlos Venegas Munoz <jose.carlos.venegas.munoz@intel.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant