-
Notifications
You must be signed in to change notification settings - Fork 374
Conversation
Fixes: kata-containers#1039 Signed-off-by: Alice Frosi <afrosi@de.ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
lgtm @alicefr - you could add another commit to this PR if you wish to remove those other |
Travis seems unhappy:
I've restarted it.. |
@jodh-intel I push with |
Hi @alicefr - your change is perfectly fine. But for consistency, it might be good to drop the diff --git a/README.md b/README.md
index 3c60d16..94094a0 100644
--- a/README.md
+++ b/README.md
@@ -52,9 +52,9 @@ See [the license file](LICENSE) for further details.
Kata Containers currently works on systems supporting the following
technologies:
-- [Intel](https://www.intel.com)'s VT-x technology.
-- [ARM](https://www.arm.com)'s Hyp mode (virtualization extension).
-- [IBM](https://www.ibm.com)'s Power Systems.
+- [Intel](https://www.intel.com) VT-x technology.
+- [ARM](https://www.arm.com) Hyp mode (virtualization extension).
+- [IBM](https://www.ibm.com) Power Systems. |
oh got it! 😅 |
@jodh-intel done! |
Thanks @alicefr! 😄 lgtm |
Oh - could you just update that 2nd commit? Our tooling is complaining as there is no "body" to that commit:
|
Drop 's for the other archs to be consistent Signed-off-by: Alice Frosi <afrosi@de.ibm.com>
Done |
Thanks @alicefr - merging this doc-only change... |
Fixes: #1039
Signed-off-by: Alice Frosi afrosi@de.ibm.com