Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

docs: add IBM Z in the README #1040

Merged
merged 2 commits into from
Dec 17, 2018
Merged

Conversation

alicefr
Copy link

@alicefr alicefr commented Dec 17, 2018

Fixes: #1039

Signed-off-by: Alice Frosi afrosi@de.ibm.com

README.md Outdated Show resolved Hide resolved
Fixes: kata-containers#1039

Signed-off-by: Alice Frosi <afrosi@de.ibm.com>
Copy link

@devimc devimc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jodh-intel
Copy link
Contributor

jodh-intel commented Dec 17, 2018

lgtm

@alicefr - you could add another commit to this PR if you wish to remove those other 's's so all the entries are consistent.

Approved with PullApprove Approved with PullApprove

@jodh-intel
Copy link
Contributor

Travis seems unhappy:

INFO: Checking all document URLs
No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated

I've restarted it..

@alicefr
Copy link
Author

alicefr commented Dec 17, 2018

@jodh-intel I push with IBM Z as we agreed, or do you want 2 commits?

@jodh-intel
Copy link
Contributor

Hi @alicefr - your change is perfectly fine.

But for consistency, it might be good to drop the 's from the other architectures (as I think they all look better without it now :). That isn't strictly part of your PR, but if you wanted to do that extra bit of tidy-up, you could add a new commit for that (sed -i "s/'s//g" README.md):

diff --git a/README.md b/README.md
index 3c60d16..94094a0 100644
--- a/README.md
+++ b/README.md
@@ -52,9 +52,9 @@ See [the license file](LICENSE) for further details.
 Kata Containers currently works on systems supporting the following
 technologies:
 
-- [Intel](https://www.intel.com)'s VT-x technology.
-- [ARM](https://www.arm.com)'s Hyp mode (virtualization extension).
-- [IBM](https://www.ibm.com)'s Power Systems.
+- [Intel](https://www.intel.com) VT-x technology.
+- [ARM](https://www.arm.com) Hyp mode (virtualization extension).
+- [IBM](https://www.ibm.com) Power Systems.

@alicefr
Copy link
Author

alicefr commented Dec 17, 2018

oh got it! 😅

@alicefr
Copy link
Author

alicefr commented Dec 17, 2018

@jodh-intel done!

@jodh-intel
Copy link
Contributor

Thanks @alicefr! 😄

lgtm

@jodh-intel
Copy link
Contributor

Oh - could you just update that 2nd commit? Our tooling is complaining as there is no "body" to that commit:

ERROR: Commit af0d1f37bddef2cff5f1df2773ad95dbc6cbf44f: single-line "Signed-off-by" body not permitted
ERROR: checkcommits failed. See the document below for help on formatting
commits for the project.

https://github.com/kata-containers/community/blob/master/CONTRIBUTING.md#patch-format

Drop 's for the other archs to be consistent

Signed-off-by: Alice Frosi <afrosi@de.ibm.com>
@alicefr
Copy link
Author

alicefr commented Dec 17, 2018

Done

@jodh-intel
Copy link
Contributor

Thanks @alicefr - merging this doc-only change...

@jodh-intel jodh-intel merged commit 006d375 into kata-containers:master Dec 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants