This repository has been archived by the owner on May 12, 2021. It is now read-only.
virtcontainers: agent: fix CPU hot plug race condition #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends-on: kata-containers/agent#182 |
sboeuf
approved these changes
Mar 21, 2018
There was a problem hiding this comment.
https://github.com/kata-containers/agent protocol needs to be re-vendored but this PR looks good.
devimc
force-pushed
the
cpu/fixRaceCondition
branch
2 times, most recently
from
51a7beb
to
95e1584
Compare
devimc
force-pushed
the
cpu/fixRaceCondition
branch
from
95e1584
to
3e0f282
Compare
|
kata-containers/agent#182 got merged , @kata-containers/runtime PTAL |
devimc
force-pushed
the
cpu/fixRaceCondition
branch
from
2cd3afa
to
3e0f282
Compare
|
Depends-on: #173 |
devimc
force-pushed
the
cpu/fixRaceCondition
branch
from
3e0f282
to
f17f28f
Compare
|
#173 got merged, PTAL |
Codecov Report
@@ Coverage Diff @@
## master #91 +/- ##
==========================================
- Coverage 65.1% 65.09% -0.02%
==========================================
Files 73 73
Lines 7695 7697 +2
==========================================
Hits 5010 5010
- Misses 2142 2144 +2
Partials 543 543
Continue to review full report at Codecov.
|
|
lgtm 🎊 |
added 2 commits
April 13, 2018 07:05
Communicate to the agent the number of vCPUs that were hot added, allowing to the agent wait for the creation of all vCPUs. fixes kata-containers#90 Signed-off-by: Julio Montes <julio.montes@intel.com>
This new version of kata-containers agent includes the fix for CPU hotplug race condition Shortlog: 131554d network: specify netlink protocol 49f01ed protocols/grpc: fix CPU hotplug race condition ee7850d mockreaper: implement mock reaper 9f60034 reaper: implement reaper interface Signed-off-by: Julio Montes <julio.montes@intel.com>
devimc
force-pushed
the
cpu/fixRaceCondition
branch
from
f17f28f
to
da6d284
Compare
|
rebased |
bergwolf
approved these changes
Apr 13, 2018
stefanha
pushed a commit
to stefanha/runtime
that referenced
this pull request
Apr 12, 2019
Shortlog: b3e7a9e Merge pull request kata-containers#91 from stefanha/virtio-fs-cache-size-mb 058cda0 qemu: use MiB instead of Gib for virtio-fs cache size Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
stefanha
pushed a commit
to stefanha/runtime
that referenced
this pull request
Apr 17, 2019
Shortlog: b3e7a9e Merge pull request kata-containers#91 from stefanha/virtio-fs-cache-size-mb 058cda0 qemu: use MiB instead of Gib for virtio-fs cache size Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
stefanha
pushed a commit
to stefanha/runtime
that referenced
this pull request
Apr 18, 2019
Shortlog: b3e7a9e Merge pull request kata-containers#91 from stefanha/virtio-fs-cache-size-mb 058cda0 qemu: use MiB instead of Gib for virtio-fs cache size Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
stefanha
pushed a commit
to stefanha/runtime
that referenced
this pull request
May 1, 2019
Shortlog: b3e7a9e Merge pull request kata-containers#91 from stefanha/virtio-fs-cache-size-mb 058cda0 qemu: use MiB instead of Gib for virtio-fs cache size Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
zklei
pushed a commit
to zklei/runtime
that referenced
this pull request
Jun 13, 2019
…ntral-check-script CI: switch to central static check script
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Communicate to the agent the number of vCPUs that were hot added,
allowing to the agent wait for the creation of all vCPUs.
fixes #90
Signed-off-by: Julio Montes julio.montes@intel.com