This repository has been archived by the owner on May 12, 2021. It is now read-only.
CI: Update bash on Travis osx for hash support #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version of `bash(1)` provided in the Travis osx environment does not support `typeset -A`, so update it using homebrew. Fixes kata-containers#98. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
grahamwhaley
approved these changes
Jul 5, 2018
|
lgtm |
|
@grahamwhaley - are you aware of issues with it? |
|
No - it's just with it being the 'unofficial package manager', and not a base part of OSX, that's all. I expect we are fine with it, and we should merge :-) |
Codecov Report
@@ Coverage Diff @@
## master #99 +/- ##
=======================================
Coverage 53.42% 53.42%
=======================================
Files 7 7
Lines 277 277
=======================================
Hits 148 148
Misses 116 116
Partials 13 13Continue to review full report at Codecov.
|
|
I came across it as its part of the standard Travis osx environment, so that might give us some level of confidence: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version of
bash(1)provided in the Travis osx environment doesnot support
typeset -A, so update it using homebrew.Fixes #98.
Signed-off-by: James O. D. Hunt james.o.hunt@intel.com