Sync changes from Periphery fork #12
Merged
+140
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ileitch
commented
Aug 25, 2024
| @@ -2,11 +2,16 @@ import Foundation | |||
| import _CIndexStore | |||
|
|
|||
| @dynamicMemberLookup | |||
| public struct LibIndexStore { | |||
| public class LibIndexStore { | |||
There was a problem hiding this comment.
I changed this to a class I observed a lot of time spent copying the store.
kateinoigakukun
approved these changes
Aug 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been maintaining a fork for Periphery and have a accumulated a number of changes. I'd like to merge them back into your repo, and follow-up with Bazel module support so that this package can be included in the BCR.
The changes here are mix of performance improvements and support for newer versions of Swift.