Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bazel module support #13

Merged
merged 1 commit into from
Aug 25, 2024
Merged

Conversation

ileitch
Copy link
Contributor

@ileitch ileitch commented Aug 25, 2024

No description provided.

@ileitch ileitch marked this pull request as ready for review August 25, 2024 13:32
@kateinoigakukun
Copy link
Owner

Do I have anything to do to publish to the registry?

@ileitch
Copy link
Contributor Author

ileitch commented Aug 25, 2024

Do I have anything to do to publish to the registry?

No, I can handle that. The only thing we need is that when you create the new release, make a copy of the auto-generated "Source code" zip and re-add it as an attachment to the release. This means that the attached archive will always have a static checksum, which isn't always the case for the auto-generated source archives.

@ileitch
Copy link
Contributor Author

ileitch commented Aug 25, 2024

Here's the draft submission to the BCR: bazelbuild/bazel-central-registry#2676

@kateinoigakukun
Copy link
Owner

Okay, thanks!

@kateinoigakukun kateinoigakukun merged commit 9363af9 into kateinoigakukun:master Aug 25, 2024
5 checks passed
@ileitch ileitch deleted the bazel branch August 25, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants