Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to exclude system units. #2

Merged
merged 2 commits into from
Oct 21, 2020
Merged

Add ability to exclude system units. #2

merged 2 commits into from
Oct 21, 2020

Conversation

ileitch
Copy link
Contributor

@ileitch ileitch commented Oct 20, 2020

I'm not really sure if it's possible to add a unit test for this, any ideas?

@kateinoigakukun
Copy link
Owner

LGTM! I guess modulemap with [system] attribute can set the isSystem flag true.

@ileitch
Copy link
Contributor Author

ileitch commented Oct 20, 2020

Yep, that works - test added.

@ileitch ileitch mentioned this pull request Oct 20, 2020
Merged
@kateinoigakukun kateinoigakukun merged commit 6c91518 into kateinoigakukun:master Oct 21, 2020
@ileitch ileitch deleted the exclude-system-units branch October 21, 2020 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kateinoigakukun kateinoigakukun kateinoigakukun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ileitch @kateinoigakukun