Fix: adding nonce as a option in wavesurfer parameters to solve CSP problems #3858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katspaugh
reviewed
Sep 6, 2024
katspaugh
reviewed
Sep 6, 2024
src/renderer.ts
Outdated
| shadow.innerHTML = ` | ||
| <style> | ||
| <style ${nonce ? `nonce="${nonce}"` : ''}> |
There was a problem hiding this comment.
This should be sanitized for XSS. Something like nonce.replace(/"/g, '')
There was a problem hiding this comment.
Like this you mean?
<style ${nonce ? `nonce="${nonce.replace(/"/g, '')}"` : ''}>There was a problem hiding this comment.
Better above where you do const nonce
There was a problem hiding this comment.
@katspaugh I've also added some type validation just to avoid any errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Resolves #3602
Implementation details
I've added the nonce property as a new parameter in the WaveSurferOptions type. In the renderer.ts it checks if it was passed, and if it was, it adds it to the style being injected. This assumes you have the nonce value in your frontend to be able to be passed as a option.
How to test it
Try adding a valid nonce value to your WaveSurfer element like this: {nonce: 'example-value'}
Screenshots
Checklist