Fix inactive consumer case #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this case CONSUMER_ID, HOST and CLIENT_ID becomes -. The current regex will fails as there is not / to detect. Rework the consumerId group to not accept / so the zero or one operator can work as expected
mayt
force-pushed
the
fix-inactive-consumer-case
branch
from
4740d0a to
6b617b5
Compare
|
LGTM 👍 thanks! |
JensRantil
reviewed
Nov 15, 2017
| @@ -51,6 +51,33 @@ topic3 0 45 45 0 consumer | |||
| }) | |||
| } | |||
|
|
|||
| func TestParsingPartitionTableWithMissingValuesConsumerIdForKafkaVersion0_10_2_1(t *T) { | |||
Yopi
pushed a commit
to Yopi/prometheus-kafka-consumer-group-exporter
that referenced
this pull request
Mar 6, 2018
In this case CONSUMER_ID, HOST and CLIENT_ID becomes -. The current regex will fails as there is not / to detect. Rework the consumerId group to not accept / so the zero or one operator can work as expected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this case CONSUMER_ID, HOST and CLIENT_ID becomes -.
The current regex will fails as there is not / to detect.
Rework the consumerId group to not accept / so the zero or one operator
can work as expected