Adding a kubectl plugin #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayrus
requested changes
Feb 6, 2023
|
|
||
| # start the sshuttle tunnel | ||
| if [[ $1 == "start" ]]; then | ||
| mkdir -p ~/.cache |
There was a problem hiding this comment.
thanks for your contribution. can you add tabs or spaces to make the code more human readable?
kayrus
reviewed
Feb 6, 2023
| @@ -0,0 +1,20 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
it also makes sense to convert the script to a plain posix shell. e.g. #!/bin/sh and add an -e flag to stop in case of errors: https://www.grymoire.com/Unix/Sh.html#uh-55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates an additional bash script that acts as a plugin to
kubectl. If this file, kuttle, and sshuttle are all in the user's path; then they may runkubectl kuttle startandkubectl kuttle stopto control their tunnel into the cluster.