Make sure connection preface is always sent first #33
Conversation
pcapriotti
force-pushed
the
preface-race
branch
from
d0be86c
to
1ee1ce4
Compare
I could do that, but then I'm not sure how to set up a test for it. Could you elaborate on how you want the waiting-forever issue to be fixed? I can try writing a patch for that first. |
pcapriotti
force-pushed
the
preface-race
branch
from
1ee1ce4
to
78c68d8
Compare
This tests that a client always sends the connection preface before any other frame (see PR kazu-yamamoto#33).
|
I rebased this branch so that it only contains the preface race fix. I wrote a patch employing async to propagate exceptions and thread termination to the main client thread, based on this one: wireapp@617c685, and the preface test is now based on both of these patches: wireapp@fb4afa7. Should I submit these as separate PRs or include them here? |
|
Thank you for brushing up this PR. What I did so far is reordering these commits:
If you kindly make this PR in this order, I'd love to merge. |
This tests that a client always sends the connection preface before any other frame (see PR kazu-yamamoto#33).
This fixes a race condition in the client between the `frameSender` thread and the main thread, in the case where a SETTINGS frame is sent in response to a server SETTINGS frame before the connection preface has had a chance to be sent.
Also throw an exception if one of the worker threads terminates before the client has received a response.
pcapriotti
force-pushed
the
preface-race
branch
from
78c68d8
to
3c269f1
Compare
Done. |
|
Merged. Thank you for your contribution! |
|
Thanks for merging!
We are fine depending on a git version, so up to you. Also, I will probably have more PRs coming in the next few days. |
|
So, I wait for the PRs. |
3.0.3 * Return correct status messages in HTTP2 client (#31)[kazu-yamamoto/http2#31] * Follow changes in Aeson 2 (#32)[kazu-yamamoto/http2#32] * Make sure connection preface is always sent first (#33)[kazu-yamamoto/http2#33] * Avoid empty data (#34)[kazu-yamamoto/http2#34] 3.0.2 * Skip inserting entries that do not fit in the encoding table (#28)[kazu-yamamoto/http2#28]
This fixes a race condition in the client between the
frameSenderthread and the main thread, in the case where a SETTINGS frame is sent in response to a server SETTINGS frame before the connection preface has had a chance to be sent.This PR also includes a commit to prevent client threads from waiting forever on stream input when the client
frameSenderthread dies. This is useful in its own right, I think, but in particular it is needed to make the test for the above fix work.