Skip to content

Bump Microsoft.NET.Test.Sdk from 17.10.0 to 17.11.1 #244

Bump Microsoft.NET.Test.Sdk from 17.10.0 to 17.11.1

Bump Microsoft.NET.Test.Sdk from 17.10.0 to 17.11.1 #244

Triggered via pull request September 6, 2024 00:36
Status Success
Total duration 36s
Artifacts

build_tests.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

10 warnings
build: src/Assistants/Thread.cs#L71
Cannot convert null literal to non-nullable reference type.
build: src/Assistants/GroupThread/GroupThread.cs#L41
Because this call is not awaited, execution of the current method continues before the call is completed. Consider applying the 'await' operator to the result of the call.
build: src/Assistants/GroupThread/GroupThread.cs#L65
Dereference of a possibly null reference.
build: src/Assistants/Models/AssistantInputParameters.cs#L27
Missing XML comment for publicly visible type or member 'AssistantInputParameter.DefaultValue'
build: src/Assistants/Models/AssistantPromptExecutionSettings.cs#L6
Missing XML comment for publicly visible type or member 'AssistantPromptExecutionSettings'
build: src/Assistants/Models/AssistantPromptExecutionSettings.cs#L50
Change 'StopSequences' to be read-only by removing the property setter (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2227)
build: src/Assistants/GroupThread/IGroupThread.cs#L24
Change the event 'OnMessageReceived' to replace the type 'System.EventHandler<Microsoft.SemanticKernel.ChatMessageContent>?' with a generic EventHandler, for example EventHandler<T>, where T is a valid EventArgs (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1003)
build: src/Assistants/AssistantBuilder.cs#L143
In externally visible method 'AssistantBuilder AssistantBuilder.WithKernelToClone(Kernel kernelToClone)', validate parameter 'kernelToClone' is non-null before using it. If appropriate, throw an 'ArgumentNullException' when the argument is 'null'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1062)
build: src/Assistants/Thread.cs#L98
For improved performance, use the LoggerMessage delegates instead of calling 'LoggerExtensions.LogInformation(ILogger, string?, params object?[])' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1848)
build: src/Assistants/Thread.cs#L98
The logging message template should not vary between calls to 'LoggerExtensions.LogInformation(ILogger, string?, params object?[])' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2254)