Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve tests for Question component #171

Closed
LaChope opened this issue Aug 25, 2022 · 3 comments
Closed

Improve tests for Question component #171

LaChope opened this issue Aug 25, 2022 · 3 comments
Assignees
@LaChope

Comments

@LaChope
Copy link
Collaborator

LaChope commented Aug 25, 2022 •
edited by blcham
Loading

New tests should be created to cover:

  • Question Layout / Style when:
    • Main color
    • Emphasized
    • Regular
  • Question is appropriately collapsed / expanded
  • Show irrelevant questions when debug mode is on or starting-question-id is assigned
  • Hide irrelevant questions when debug mode is off
  • Icons are properly attached to Question
@LaChope LaChope self-assigned this Aug 25, 2022
@LaChope LaChope mentioned this issue Aug 25, 2022
Open
LaChope added a commit that referenced this issue Aug 26, 2022
@LaChope
[New #171] Add stories for Question Component
56848b0
LaChope added a commit that referenced this issue Aug 26, 2022
@LaChope
[New #171] Add stories and tests for Question Component
fd24c03
@LaChope
Copy link
Collaborator Author

LaChope commented Aug 26, 2022

@blcham you can check last commit fd24c03 if you want to have a first look

LaChope added a commit that referenced this issue Aug 26, 2022
@LaChope
[New #171] Add stories and tests for Question Component
3848e3b
@blcham
Copy link
Collaborator

blcham commented Aug 26, 2022

@blcham you can check last commit fd24c03 if you want to have a first look

Thanks, looks nice.

@LaChope LaChope mentioned this issue Aug 30, 2022
Merged
@blcham
Copy link
Collaborator

blcham commented Sep 1, 2022

Closed by #163.

@blcham blcham closed this as completed Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LaChope LaChope

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@blcham @LaChope