[#209] React and React DOM upgraded to v18 #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…torybook, react component libs, testing libs,...) synchronised. Work in progress. Library for global storybook controls has React 18 as optional peer dependency, need to examine closer.
✅ Deploy Preview for s-forms-kbss ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…ormed to new standard of storybook (CSF3).
…rybook. Decorators might need further work to make it simple and unified
blcham
approved these changes
Jul 12, 2023
| expect(picker.props().showTimeSelect).toEqual(true); | ||
| expect(picker.props().showTimeSelectOnly).toEqual(false); | ||
| expect(picker.props().selected).toEqual(new Date(value)); | ||
| expect(screen.queryByText("Time")).toBeNull(); |
There was a problem hiding this comment.
This is quite strange ... we should reconsider how to do this and create an issue for it.
| @@ -1,7 +1,7 @@ | |||
| import enzyme, { shallow, mount } from "enzyme"; | |||
| import Adapter from "@wojtekmaj/enzyme-adapter-react-17"; | |||
| import Adapter from "@cfaester/enzyme-adapter-react-18"; | |||
There was a problem hiding this comment.
We need to get rid of this in a future issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependencies synchronised to correspond to React 18. Work in progress. Library for global storybook controls has React 18 as optional peer dependency, need to examine closer.