Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor enhance: expose GetSchemaTypeMapping Go API #124

Merged
merged 1 commit into from
Jul 25, 2023
Merged

minor enhance: expose GetSchemaTypeMapping Go API #124

merged 1 commit into from
Jul 25, 2023

Conversation

amyXia1994
Copy link
Contributor

@amyXia1994 amyXia1994 commented Jul 25, 2023 •
edited
Loading

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

.gitignore
kclvm.go
kclvm_test.go
pkg/kcl/api.go

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

minor enhance: expose GetSchemaTypeMapping Go API

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@amyXia1994 amyXia1994 requested review from Peefy and chai2010 and removed request for Peefy July 25, 2023 07:11
Peefy
Peefy approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit e7b505e into kcl-lang:main Jul 25, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2023
@amyXia1994 amyXia1994 deleted the enhance/expose-GetSchemaTypeMapping-api branch July 26, 2023 02:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Peefy Peefy Peefy approved these changes

@chai2010 chai2010 Awaiting requested review from chai2010

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support Go API for GetSchemaTypeMapping
2 participants
@amyXia1994 @Peefy