-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support more keywords when generating from json schema #131
Conversation
Pull Request Test Coverage Report for Build 5794201689
💛 - Coveralls |
2840e03
to
02d6ecb
Compare
|
||
name?: str | ||
socket?: Socket = {"HTTP": 80, "HTTPS": 443} | ||
[...str]: any |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the index signature [...str]: any
here will still be retained?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Job! LGTM
1. Does this PR affect any open issues?(Y/N) and add issue references
part of kcl-lang/kcl#526
2. What is the scope of this PR (e.g. component or file name):
pkg/tools/gen
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
Support convert
const
,$ref
,$defs
andadditionalProperties
keywords from json schema to kcl schema.Add
getSortedKeys
function for more ordered and stable results.4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links: