Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sync kcl v0.5.4 APIs and update test cases. #136

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Aug 16, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

feat: sync kcl v0.5.4 APIs and update test cases.

  • add DefaultValue showing for GetSchemaType API
  • add IncludeSchemaTypePath option for Run API

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • kclvm_test.go

@Peefy Peefy added the api label Aug 16, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5875032655

  • 4 of 11 (36.36%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 62.527%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/kcl/opt.go 1 8 12.5%
Files with Coverage Reduction New Missed Lines %
pkg/tools/format/kformat.go 2 54.55%
Totals Coverage Status
Change from base Build 5873992854: -0.1%
Covered Lines: 2281
Relevant Lines: 3648

💛 - Coveralls

@Peefy Peefy merged commit afc1b9f into kcl-lang:main Aug 16, 2023
6 checks passed
@Peefy Peefy deleted the bump-kcl-version-to-0.5.4 branch August 16, 2023 05:52
@github-actions github-actions bot locked and limited conversation to collaborators Aug 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support Go API for GetSchemaTypeMapping
2 participants