Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance doc gen tool: support custom template #147

Merged
merged 5 commits into from
Aug 30, 2023

Conversation

amyXia1994
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

related to #139

2. What is the scope of this PR (e.g. component or file name):

cmds/kcl-go/command/cmd_doc.go
pkg/tools/gen/gendoc.go
pkg/tools/gen/gendoc_test.go

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

Enhance doc gen tool: support custom template

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@Peefy Peefy merged commit bc9e918 into kcl-lang:main Aug 30, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2023
@amyXia1994 amyXia1994 deleted the update/support-custom-template branch August 31, 2023 03:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support Go API for GetSchemaTypeMapping
2 participants