Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add testing APIs #184

Merged
merged 1 commit into from
Nov 24, 2023
Merged

feat: add testing APIs #184

merged 1 commit into from
Nov 24, 2023

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Nov 24, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y
  • feat: add testing APIs

2. What is the scope of this PR (e.g. component or file name):

  • kclvm.go
  • pkg/tools/testing/indent.go
  • pkg/tools/testing/reporter.go
  • pkg/tools/testing/testing.go

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • pkg/tools/testing/reporter_test.go
  • kclvm_test.go

Signed-off-by: peefy <xpf6677@163.com>
@Peefy Peefy added the api label Nov 24, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6976697057

  • 57 of 124 (45.97%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 63.014%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/tools/testing/reporter.go 33 45 73.33%
pkg/tools/testing/indent.go 0 22 0.0%
pkg/tools/testing/testing.go 21 54 38.89%
Totals Coverage Status
Change from base Build 6976129650: -0.5%
Covered Lines: 2680
Relevant Lines: 4253

💛 - Coveralls

Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy added the tool label Nov 24, 2023
@Peefy Peefy merged commit 17b297a into kcl-lang:main Nov 24, 2023
7 checks passed
@Peefy Peefy deleted the add-testing-api branch November 24, 2023 04:08
@github-actions github-actions bot locked and limited conversation to collaborators Nov 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support Go API for GetSchemaTypeMapping
3 participants