Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: jsonschema stmt import #376

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Aug 27, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

Closes kcl-lang/cli#139

refactor: jsonschema stmt import

Signed-off-by: peefy <xpf6677@163.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10576054159

Details

  • 71 of 162 (43.83%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 32.916%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/tools/gen/genkcl_jsonschema.go 71 162 43.83%
Files with Coverage Reduction New Missed Lines %
pkg/tools/gen/genkcl_jsonschema.go 1 69.21%
Totals Coverage Status
Change from base Build 10504161677: 0.1%
Covered Lines: 5814
Relevant Lines: 17663

💛 - Coveralls

2 similar comments
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10576054159

Details

  • 71 of 162 (43.83%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 32.916%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/tools/gen/genkcl_jsonschema.go 71 162 43.83%
Files with Coverage Reduction New Missed Lines %
pkg/tools/gen/genkcl_jsonschema.go 1 69.21%
Totals Coverage Status
Change from base Build 10504161677: 0.1%
Covered Lines: 5814
Relevant Lines: 17663

💛 - Coveralls

@coveralls
Copy link

coveralls commented Aug 27, 2024

Pull Request Test Coverage Report for Build 10576054159

Details

  • 71 of 162 (43.83%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 32.916%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/tools/gen/genkcl_jsonschema.go 71 162 43.83%
Files with Coverage Reduction New Missed Lines %
pkg/tools/gen/genkcl_jsonschema.go 1 69.21%
Totals Coverage Status
Change from base Build 10504161677: 0.1%
Covered Lines: 5814
Relevant Lines: 17663

💛 - Coveralls

@Peefy Peefy merged commit ba9cd75 into kcl-lang:main Aug 27, 2024
13 checks passed
@Peefy Peefy deleted the refactor-jsonschema-stmt-import branch August 27, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kcl import do not recognize jsnoschema statements support Go API for GetSchemaTypeMapping
2 participants