-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine illegal attr ty err msg #100
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peefy
added
enhancement
New feature or request
semantic
Issues or PRs related to kcl semantic and checker
type-system
Issues or PRs related to kcl type system
labels
Jul 4, 2022
Pull Request Test Coverage Report for Build 2779970573
💛 - Coveralls |
Peefy
changed the title
Refine illegal attr ty err msg
[WIP] Refine illegal attr ty err msg
Jul 7, 2022
Peefy
force-pushed
the
refine-illegal-attr-ty-err-msg
branch
2 times, most recently
from
July 18, 2022 13:04
8b6860c
to
a762665
Compare
Peefy
changed the title
[WIP] Refine illegal attr ty err msg
Refine illegal attr ty err msg
Jul 21, 2022
Peefy
changed the title
Refine illegal attr ty err msg
[WIP] Refine illegal attr ty err msg
Jul 22, 2022
Peefy
changed the title
[WIP] Refine illegal attr ty err msg
Refine illegal attr ty err msg
Jul 25, 2022
Peefy
changed the title
Refine illegal attr ty err msg
[WIP] Refine illegal attr ty err msg
Jul 25, 2022
Peefy
force-pushed
the
refine-illegal-attr-ty-err-msg
branch
from
July 27, 2022 04:09
a762665
to
ff4aa25
Compare
Peefy
changed the title
[WIP] Refine illegal attr ty err msg
Refine illegal attr ty err msg
Aug 1, 2022
Peefy
force-pushed
the
refine-illegal-attr-ty-err-msg
branch
from
August 2, 2022 06:08
ff4aa25
to
c12794f
Compare
He1pa
approved these changes
Aug 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
zong-zhe
approved these changes
Aug 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
enhancement
New feature or request
semantic
Issues or PRs related to kcl semantic and checker
type-system
Issues or PRs related to kcl type system
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
[Enhancement] #99
2. What is the scope of this PR (e.g. component or file name):
KCLVM Resolver Related Files:
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
See #99, the error messages are improved
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:
test_resolve_program_illegal_attr_fail
inkclvm/sema/src/resolver/tests.rs
6. Release note
Please refer to Release Notes Language Style Guide to write a quality release note.