Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine illegal attr ty err msg #100

Merged
merged 1 commit into from
Aug 5, 2022

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Jul 4, 2022

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

[Enhancement] #99

2. What is the scope of this PR (e.g. component or file name):

KCLVM Resolver Related Files:

  • kclvm/sema/src/resolver/node.rs
  • kclvm/sema/src/resolver/attr.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

See #99, the error messages are improved

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • test_resolve_program_illegal_attr_fail in kclvm/sema/src/resolver/tests.rs

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Peefy Peefy added enhancement New feature or request semantic Issues or PRs related to kcl semantic and checker type-system Issues or PRs related to kcl type system labels Jul 4, 2022
@Peefy Peefy added this to the v0.4.3 Release milestone Jul 4, 2022
@Peefy Peefy requested a review from a team July 4, 2022 03:27
@Peefy Peefy self-assigned this Jul 4, 2022
@coveralls
Copy link
Collaborator

coveralls commented Jul 4, 2022

Pull Request Test Coverage Report for Build 2779970573

  • 30 of 30 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 58.937%

Totals Coverage Status
Change from base Build 2772849165: -0.5%
Covered Lines: 21297
Relevant Lines: 36135

💛 - Coveralls

@Peefy Peefy requested review from chai2010 and zong-zhe July 5, 2022 09:47
@Peefy Peefy changed the title Refine illegal attr ty err msg [WIP] Refine illegal attr ty err msg Jul 7, 2022
@Peefy Peefy force-pushed the refine-illegal-attr-ty-err-msg branch 2 times, most recently from 8b6860c to a762665 Compare July 18, 2022 13:04
@Peefy Peefy changed the title [WIP] Refine illegal attr ty err msg Refine illegal attr ty err msg Jul 21, 2022
@Peefy Peefy requested a review from He1pa July 22, 2022 05:51
@Peefy Peefy changed the title Refine illegal attr ty err msg [WIP] Refine illegal attr ty err msg Jul 22, 2022
@Peefy Peefy changed the title [WIP] Refine illegal attr ty err msg Refine illegal attr ty err msg Jul 25, 2022
@Peefy Peefy changed the title Refine illegal attr ty err msg [WIP] Refine illegal attr ty err msg Jul 25, 2022
@Peefy Peefy force-pushed the refine-illegal-attr-ty-err-msg branch from a762665 to ff4aa25 Compare July 27, 2022 04:09
@Peefy Peefy changed the title [WIP] Refine illegal attr ty err msg Refine illegal attr ty err msg Aug 1, 2022
@Peefy Peefy force-pushed the refine-illegal-attr-ty-err-msg branch from ff4aa25 to c12794f Compare August 2, 2022 06:08
Copy link
Contributor

@He1pa He1pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 2d527ed into kcl-lang:main Aug 5, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 5, 2022
@Peefy Peefy deleted the refine-illegal-attr-ty-err-msg branch August 5, 2022 06:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request semantic Issues or PRs related to kcl semantic and checker type-system Issues or PRs related to kcl type system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants