-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(resolver): fix incorrect position info of CannotFindModule Error. #128
Conversation
Pull Request Test Coverage Report for Build 2772064760
💛 - Coveralls |
7ab00f1
to
e9802b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There is an incorrect position of ConnotFindModule Error. When a CannotFindModule error is triggered (e.g., importing a non-existent file), the error message is indicated at x:2(line: x and column: 2), but by convention it should be x:1 or just line x. Now fix it to just output the line number. ``` KCL Error [CannotFindModule] ---> File ./test.k:1 1 |import non_existent_file ``` fix kcl-lang#126
f3cea26
to
24ada37
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
2. What is the scope of this PR (e.g. component or file name):
sema/resolver/global.rs
sema/resolver/import.rs
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
There is an incorrect position of ConnotFindModule Error. When a CannotFindModule error is triggered (e.g., importing a non-existent file), the error message is indicated at x:2(line: x and column: 2), but by convention it should be x:1 or just line x. Now fix it to just output the line number.
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:
6. Release note
Please refer to Release Notes Language Style Guide to write a quality release note.