Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump cli clap deps to latest, use new apis and remove unused a… #205

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Sep 19, 2022

…rguments.

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

According to https://github.com/KusionStack/KCLVM/security/dependabot/40, upgrade clap crate deps version.
Bump cli clap deps to latest, use new apis and remove unused arguments.

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Peefy Peefy added this to the v0.4.4 Release milestone Sep 19, 2022
@Peefy Peefy self-assigned this Sep 19, 2022
Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@He1pa He1pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 3079527955

  • 0 of 5 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 60.432%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/src/main.rs 0 5 0.0%
Totals Coverage Status
Change from base Build 3079386482: 0.01%
Covered Lines: 23789
Relevant Lines: 39365

💛 - Coveralls

@Peefy Peefy merged commit 5b98bb8 into kcl-lang:main Sep 19, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2022
@Peefy Peefy deleted the upgrade-rust-clap-deps branch November 4, 2022 12:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants