Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(kclvm-codegen): fix schema back ref. #232

Merged
merged 2 commits into from
Oct 11, 2022
Merged

Fix(kclvm-codegen): fix schema back ref. #232

merged 2 commits into from
Oct 11, 2022

Conversation

zong-zhe
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

issue #231

2. What is the scope of this PR (e.g. component or file name):

kclvm-codegen

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

fix schema back reference exception.

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

fix schema back reference exception.

issue #231
@zong-zhe zong-zhe added bug Something isn't working fix labels Oct 10, 2022
@zong-zhe zong-zhe added this to the v0.4.4 Release milestone Oct 10, 2022
@zong-zhe zong-zhe self-assigned this Oct 10, 2022
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 3219451710

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 501 unchanged lines in 13 files lost coverage.
  • Overall coverage decreased (-0.7%) to 57.494%

Files with Coverage Reduction New Missed Lines %
kclvm/3rdparty/rustc_span/src/source_map.rs 1 27.95%
kclvm/lexer/src/lib.rs 1 78.65%
kclvm/sema/src/ty/into.rs 1 78.33%
kclvm/sema/src/ty/unify.rs 1 93.91%
kclvm/parser/src/lexer/indent.rs 5 78.31%
kclvm/tools/src/vet/tests.rs 8 96.1%
kclvm/tools/src/vet/expr_builder.rs 9 95.26%
kclvm/3rdparty/rustc_span/src/analyze_source_file.rs 10 75.26%
kclvm/3rdparty/rustc_span/src/lib.rs 17 33.75%
kclvm/sema/src/ty/mod.rs 35 66.02%
Totals Coverage Status
Change from base Build 3213156415: -0.7%
Covered Lines: 19379
Relevant Lines: 33706

💛 - Coveralls

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy added the codegen label Oct 11, 2022
Copy link
Contributor

@chai2010 chai2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zong-zhe zong-zhe merged commit 93ee39e into kcl-lang:main Oct 11, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working codegen fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants