Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(kclvm-win): Added the missing kclvm-python in build.bat. #358

Merged
merged 1 commit into from
Jan 3, 2023
Merged

Fix(kclvm-win): Added the missing kclvm-python in build.bat. #358

merged 1 commit into from
Jan 3, 2023

Conversation

zong-zhe
Copy link
Contributor

@zong-zhe zong-zhe commented Jan 3, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

issue #357

2. What is the scope of this PR (e.g. component or file name):

Added the missing kclvm-python in build.bat.

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@zong-zhe zong-zhe self-assigned this Jan 3, 2023
@zong-zhe zong-zhe added windows Only for windows. bug Something isn't working labels Jan 3, 2023
@zong-zhe zong-zhe added this to the v0.4.5 Release milestone Jan 3, 2023
@coveralls
Copy link
Collaborator

coveralls commented Jan 3, 2023

Pull Request Test Coverage Report for Build 3827612139

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-28.1%) to 61.588%

Totals Coverage Status
Change from base Build 3738956244: -28.1%
Covered Lines: 21992
Relevant Lines: 35708

💛 - Coveralls

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy added the release label Jan 3, 2023
Copy link
Contributor

@chai2010 chai2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 57f0054 into kcl-lang:main Jan 3, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working release windows Only for windows.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants