Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rust code coverage in makefile and github actions. #85

Merged
merged 1 commit into from
Jun 10, 2022

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Jun 9, 2022

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

#50 Enahcne the rust code ci test and output code coverage.

Since KCLVM rust completely changed the workspace mode compilation, the path of the runtime library compilation has changed, and the windows compilation script needs to be adjusted.

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

CI test integration

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Peefy Peefy added enhancement New feature or request ci labels Jun 9, 2022
@Peefy Peefy added this to the v0.4.3 Release milestone Jun 9, 2022
@Peefy Peefy requested review from chai2010, amyXia1994, ldxdl, He1pa, zong-zhe and a team June 9, 2022 06:39
@Peefy Peefy self-assigned this Jun 9, 2022
@Peefy Peefy force-pushed the dev/peefy/feat_cargo_codecov branch 2 times, most recently from 39d6fcf to b2fa7de Compare June 9, 2022 11:00
@Peefy Peefy changed the title WIP: feat: add rust code coverage in makefile and github actions. feat: add rust code coverage in makefile and github actions. Jun 9, 2022
@Peefy Peefy force-pushed the dev/peefy/feat_cargo_codecov branch from b2fa7de to f308e05 Compare June 9, 2022 12:31
Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ldxdl ldxdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldxdl ldxdl merged commit d9180a0 into main Jun 10, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 10, 2022
@Peefy Peefy deleted the dev/peefy/feat_cargo_codecov branch June 20, 2022 08:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ci enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants