-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add basic batteries #41
base: main
Are you sure you want to change the base?
Conversation
README.md
Outdated
- `flowcontrol` - Kubernetes native flow control using `flowcontrol.apiserver.k8s.io` | ||
|
||
|
||
When starting server without any flags, in-memory storage will be used and batteries will be disabled by default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does in-memory storage mean? You mean you wire through no-op informers I assume?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in-memory etcd - our usual standalone development mode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ack
server/cmd/server.go
Outdated
@@ -39,6 +38,8 @@ import ( | |||
cliflag "k8s.io/component-base/cli/flag" | |||
"k8s.io/component-base/cli/globalflag" | |||
"k8s.io/component-base/logs" | |||
|
|||
apiextensionapiserver "k8s.io/apiextensions-apiserver/pkg/apiserver" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
strange order
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
at some point need to wire linters into this repo :/ still very much basic stuff only
Summary
Adds basic batteries to the control plane. This is not final state, but more to try and see what block are turnabble off and which ones needs some more upstream changes. This way we can experiment easier and get to proper decomposed control planes
Related issue(s)
Fixes #
Release Notes